-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix primary storage update form not showing existing values #9809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix primary storage update form not showing existing values #9809
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #9809 +/- ##
============================================
- Coverage 15.08% 15.08% -0.01%
- Complexity 11198 11201 +3
============================================
Files 5404 5404
Lines 473418 473417 -1
Branches 60717 61775 +1058
============================================
- Hits 71425 71416 -9
- Misses 394044 394053 +9
+ Partials 7949 7948 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
weizhouapache
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm
|
@kiranchavala a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build failed: ✖️ |
|
@kiranchavala a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build failed: ✖️ |
|
@blueorangutan package |
|
@kiranchavala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11373 |
sureshanaparti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
kiranchavala
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.


Description
Fixes the bug described in #9806. The primary storage update form is not showing the existing values of the following fields: tags, is tag a rule, capacity bytes, IOPS total and NFS mount options.
Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
I accessed a NFS primary storage's details page, enabled maintenance mode and edited its name, tags, tag as JS rule, capacity bytes, IOPS total and NFS mount options fields. Then, I opened the edit form again and verified that the updated values were shown.